Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store ADF config before it needs to be read the first time #548

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

sbkok
Copy link
Collaborator

@sbkok sbkok commented Oct 12, 2022

Why?

After deploying ADF for the first time, it will need to store the adfconfig.yml values in the AWS Systems Manager Parameter Store. Such that the logic inside the account bootstrap and account management state machines can execute correctly.

At the moment, the config is written after the Step Functions are triggered by syncing account configurations to S3. This will fail on the read of the config parameter.

What?

Adding another step that will only store the configuration values in the ADF Bootstrap CodeBuild execution. Before it copies the files that would trigger the account management and account bootstrapping state machines.


By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.

**Why?**

After deploying ADF for the first time, it will need to store the adfconfig.yml
values in the AWS Systems Manager Parameter Store. Such that the logic inside
the account bootstrap and account management state machines can execute
correctly.

At the moment, the config is written after the Step Functions are triggered by
syncing account configurations to S3. This will fail on the read of the
`config` parameter.

**What?**

Adding another step that will only store the configuration values in the ADF
Bootstrap CodeBuild execution. Before it copies the files that would trigger
the account management and account bootstrapping state machines.
@sbkok sbkok added the bug Something isn't working label Oct 12, 2022
@sbkok sbkok added this to the v3.2.0 milestone Oct 12, 2022
@sbkok sbkok merged commit 281ffef into awslabs:master Oct 26, 2022
@sbkok sbkok deleted the fix/store-config-before-initial-use branch October 26, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants