Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor line length and minor code style changes throughout ADF #490

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

sbkok
Copy link
Collaborator

@sbkok sbkok commented Aug 17, 2022

Why?

The files touch upon in this change set did not follow the correct line
length that is defined by the EditorConfig.

While going through the lines, I also noticed a few comments and code blocks
that needed to be improved.

What?

  • Changed the line lengths and minor adjustments in comments where required.
  • Added new lines before resource definitions in the CloudFormation templates so it is easier to navigate and read.
  • Minor refactoring of the code where needed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

**Why?**

The files touch upon in this change set did not follow the correct line
length that is defined by the EditorConfig.

While going through the lines, I also noticed a few comments and code blocks
that needed to be improved.

**What?**

* Changed the line lengths and minor adjustments in comments where required.
* Refactored code where needed.
@sbkok sbkok requested review from javydekoning and StewartW August 17, 2022 14:30
Copy link
Contributor

@javydekoning javydekoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should consider adding a linter for this later.

@sbkok
Copy link
Collaborator Author

sbkok commented Aug 17, 2022

Absolutely, I am planning to introduce black after we released 3.2.0. So it does not conflict with our PRs that introduce large change sets at the moment.

@sbkok sbkok merged commit 80cdbe9 into awslabs:master Aug 18, 2022
@sbkok sbkok deleted the fix/line-lengths branch August 18, 2022 13:59
@sbkok sbkok added this to the v3.2.0 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants