-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not add duplicate inputs #446
Conversation
When using the `param_overrides` functionality. And you use 2 parameters from the same source. The artifact is added twice to the action. This causes the pipeline to fail. Issue: awslabs#445
3bde993
to
b88c7a2
Compare
b88c7a2
to
5d6bdb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing a fix for this issue.
Could you please add test cases to the following file [0] to verify that this works correctly?
That way we know it will continue to work in the future, even if this part gets refactored.
@sbkok I added 2 tests:
Also added some context on how to run the top build locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the tests too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually ran our latest CI on this. All checks are passing.
PR LGTM! Thanks for contributing.
Issue #, if available: #445
Description of changes:
When using the
param_overrides
functionality. And you use 2 parameters from the same source. The artifact is added twice to the action. This causes the pipeline to fail.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.