Refactoring Account management to use a step function #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StewartW
force-pushed
the
refactor/account-processing
branch
from
bd999ae to
07ddd38
Compare
StewartW
force-pushed
the
refactor/account-processing
branch
from
81466a3 to
5192ae7
Compare
Linting, tests and reducing IAM role scope Enabling tracing Refactoring some more
StewartW
force-pushed
the
refactor/account-processing
branch
3 times, most recently
from
80ee274 to
a9696e9
Compare
StewartW
force-pushed
the
refactor/account-processing
branch
from
a9696e9 to
1c7f6d6
Compare
sbkok
requested changes
Nov 12, 2021
src/lambda_codebase/account_processing/process_account_files.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/account_processing/process_account_files.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/account_processing/register_account_for_support.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/account_processing/register_account_for_support.py
Outdated
Show resolved
Hide resolved
…into refactor/account-processing
Co-authored-by: Simon Kok <[email protected]>
…-deployment-framework into refactor/account-processing
…pport.py Co-authored-by: Simon Kok <[email protected]>
Co-authored-by: Simon Kok <[email protected]>
StewartW
force-pushed
the
refactor/account-processing
branch
from
7362272 to
05132e6
Compare
…-deployment-framework into refactor/account-processing
StewartW
force-pushed
the
refactor/account-processing
branch
from
05132e6 to
f924ce0
Compare
sbkok
requested changes
Nov 17, 2021
src/lambda_codebase/account_processing/configure_account_tags.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/account_processing/tests/test_account_file_processing.py
Show resolved
Hide resolved
src/lambda_codebase/account_processing/tests/test_account_file_processing.py
Show resolved
Hide resolved
…into refactor/account-processing
Co-authored-by: Simon Kok <[email protected]>
sbkok
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Removed main.py from the provisioner dir and the buildspec.
Now account files are synced to a new bucket, which is farmed out to a step function per account.
Step function then decided if it needs to create the account / enable enterprise support . Then will Update OU, Tags and alias as necessary before getting all available regions and deleting the default vpc in those regions if configured.
Roughly looks like this:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.