Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds retry for InvalidTemplateError and GenericAccountConfigureError #384

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

tylergohl
Copy link
Contributor

Issue #, if available:
#383

Description of changes:
Adds a retry for InvalidTemplateError and GenericAccountConfigureError that addresses a race condition that occurs with new accounts are initially joined to an organization.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@StewartW StewartW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tylergohl
Copy link
Contributor Author

Hi @StewartW - what steps do we need to take to get this approved and merged in for a new release? Anything I can do to help there? Thanks!

@StewartW StewartW requested a review from sbkok October 25, 2021 10:36
@sbkok sbkok added this to the v3.2.0 milestone Nov 5, 2021
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing this!

@sbkok sbkok merged commit 0b24462 into awslabs:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants