F/fix partition python #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsudduth
force-pushed
the
f/fix-partition-python
branch
from
093e5ba to
c16a253
Compare
Hi @StewartW, I agree, #343 would no longer be needed. I've squashed the changes down significantly, keeping a few. Let me know if we need to change anything else. Thanks again for the review! |
sbkok
requested changes
Nov 5, 2021
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
sbkok
approved these changes
Nov 5, 2021
StewartW
approved these changes
Nov 8, 2021
Changes look good. Thanks for making them
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#332
Description of changes:
This Pull Request adds support for GovCloud customers and regions. As described in #332, the changes focus on dynamically setting the partition.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.