Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specifying tag on CodeBuild repository image to use #377

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

sbkok
Copy link
Collaborator

@sbkok sbkok commented Jul 21, 2021

Why?
As reported in issue #374, the schema validation looks for a dictionary
of tags when a repository_arn is set. While the rest of the code, tests, and
documentation talk about a tag string.

What?
This change requests updates the schema to fix this issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

**Why?**
As reported in issue awslabs#374, the schema validation looks for a dictionary
of tags when a `repository_arn` is set. While the rest of the code, tests, and
documentation talk about a tag string.

**What?**
This change requests updates the schema to fix this issue.
@sbkok sbkok added this to the v3.2.0 milestone Jul 21, 2021
Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@deltagarrett deltagarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbkok sbkok merged commit 075be17 into awslabs:master Jul 22, 2021
@sbkok sbkok deleted the fix/codebuild-image-tag branch July 22, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants