Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in the ability to use ChatBot configurations #367

Merged
merged 17 commits into from
Nov 12, 2021

Conversation

StewartW
Copy link
Contributor

@StewartW StewartW commented May 27, 2021

Issue #, if available:
#257

Description of changes:
Enabled AWS ChatBot for pipeline notifications.
Fixed a bug where multiple pipelines would result in a policy size exceeded error

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StewartW StewartW force-pushed the pipeline-notification-fixes branch from dbbdd9a to d7ec3b0 Compare May 27, 2021 11:28
@StewartW StewartW marked this pull request as ready for review May 27, 2021 13:04
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this feature. A few small changes requested 👍

docs/admin-guide.md Outdated Show resolved Hide resolved
docs/admin-guide.md Outdated Show resolved Hide resolved
docs/admin-guide.md Outdated Show resolved Hide resolved
docs/admin-guide.md Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
@sbkok sbkok added the enhancement New feature or request label Nov 8, 2021
@sbkok sbkok linked an issue Nov 8, 2021 that may be closed by this pull request
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sbkok sbkok requested a review from deltagarrett November 10, 2021 14:51
Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sbkok sbkok merged commit 3bd2969 into awslabs:master Nov 12, 2021
Copy link

@deltagarrett deltagarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Pipelines with Slack Notifications breaks pipeline Generation
4 participants