Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded napi_no_external_buffers_allowed value for Node 21 and below #508

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

xiazhvera
Copy link
Contributor

This reverts commit 0aa0feb.

Issue #, if available:

Description of changes:
The enum napi_no_external_buffers_allowed is introduced in node21 and backport to node 14.21.2, 16.19.0, 18.13.0.
(Details in : nodejs/node#45181)
We hardcoded napi_no_external_buffers_allowed value until we upgrade to node21.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera marked this pull request as ready for review November 29, 2023 23:51
@xiazhvera xiazhvera merged commit 990fbbe into main Dec 1, 2023
29 checks passed
@xiazhvera xiazhvera deleted the external_buffer_fix branch December 1, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants