Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test leak for MQTT #790

Merged
merged 3 commits into from
May 30, 2024
Merged

fix test leak for MQTT #790

merged 3 commits into from
May 30, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented May 29, 2024

Issue #, if available:

  • Specifically, IotServiceTest.testIotService, when connectDirectWithConfig failed, there is no close() called for the connection, here, while the connection may already be created by failed to connect, here, and result in a resource leak. And result in the test hanging as we wait for the resources to be cleaned up

Description of changes:

  • Add a tear down override to make sure the connection is closed before exit
  • Remove badssl tests, they are flaky and I don't know why we have those similar tests to different endpoint

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK merged commit 5f6f2d2 into main May 30, 2024
42 checks passed
@TingDaoK TingDaoK deleted the fix-mqtt-test-leak branch May 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants