More Error Info #683
More Error Info #683
Conversation
| */ | ||
| public enum CrtErrorInfo { | ||
| Success(0), | ||
| TLSNegotiationFailure(1029), |
There was a problem hiding this comment.
We should code-gen these!
Waqar took a swing at doing this for aws-crt-swift a few months back. It didn't get merged for various reasons, but I'd love to take the cod-gen approach for errors in all CRTs:
Here's Waqar's code-genned enum list:
https://github.com/awslabs/aws-crt-swift/blob/fix-error-handling-2/Source/AwsCommonRuntimeKit/crt/CRTErrorGenerated.swift
Here's his code-gen script:
https://github.com/awslabs/aws-crt-swift/blob/fix-error-handling-2/Source/Script/CRTErrorGenerator.swift
We could have a CI step that confirms it's up to date (run script, fail if file changes)
There was a problem hiding this comment.
deferring this convo to a later time. For now I can get by with the errir code being made public on the exception class
| @@ -6,13 +6,14 @@ | |||
| package software.amazon.awssdk.crt.http; | |||
|
|
|||
| import software.amazon.awssdk.crt.CRT; | |||
| import software.amazon.awssdk.crt.CrtErrorInfo; | |||
|
|
|||
| /** | |||
| * This exception will be thrown by any exceptional cases encountered within the | |||
| * JNI bindings to the AWS Common Runtime | |||
| */ | |||
| public class HttpException extends RuntimeException { | |||
There was a problem hiding this comment.
My real dream for aws-crt-java would be to code-gen actual exception classes (not just enums) so Java programmers could do the idiomatic thing and:
catch (TlsNegotiationFailure e) {
...special...
}
catch (Exception e) {
...everything else...
}
instead of:
catch (HttpException e) {
switch(e.getErrorInfo()) {
case CrtErrorInfo.TLSNegotiationFailure:
...special...
break;
default:
...everything else (block 1)...
break;
}
}
catch (Exception e) {
...everything else (block 2)...
}
But that would technically be a breaking change, since we'd be changing the exact exception classes that get raised 😓
Would it be worth breaking those eggs?
There was a problem hiding this comment.
deferring this convo to a later time. For now I can get by with the errir code being made public on the exception class
Working on java sdk and I needed to know what the error was so I could adapt it to the exception contract of the java sdk http spi. CRT needs to be definitive on what the error was, rather than users embedding codes such as 1029 into their application codebases. So put it here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.