Fix crashes in GCC 4.x shared-libs builds, due to recent symbol visibility changes #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
approved these changes
Nov 4, 2024
DmitriyMusatkin
approved these changes
Nov 4, 2024
sbera87
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ility changes (#675) **Issue:** When building with GCC 4.8 and 4.9 and `-DBUILD_SHARED_LIBS=ON`, many tests were crashing. The crashes would say something like "free(): invalid pointer" and the stack trace would point into the c++ string headers. **Things we tried** - Crash stopped if we commented out the [recently-added line in CMakeLists.txt](https://github.com/awslabs/aws-crt-cpp/blob/80f4736126e14223a0c3882d3b734607143731f3/CMakeLists.txt#L305) line that sets `CXX_VISIBILITY_PRESET hidden`. So obviously symbol visibility has something to do with it. - We tried adding adding `AWS_CRT_CPP_API` to the templated `StlAllocator` class (see edfed14), which stopped GCC 4.x from crashing, but then the [Windows compiler didn't like that](https://github.com/awslabs/aws-crt-cpp/actions/runs/11636848409/job/32409003392#step:2:2373). **Description of Changes:** Don't set visibility to hidden for GCC < 5. That's how we had it before. GCC 4.x is very old. This isn't the first time it's disappointed us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When building with GCC 4.8 and 4.9 and
-DBUILD_SHARED_LIBS=ON, many tests were crashing. The crashes would say something like "free(): invalid pointer" and the stack trace would point into the c++ string headers.Things we tried
CXX_VISIBILITY_PRESET hidden. So obviously symbol visibility has something to do with it.AWS_CRT_CPP_APIto the templatedStlAllocatorclass (see edfed14), which stopped GCC 4.x from crashing, but then the Windows compiler didn't like that.Description of Changes:
Don't set visibility to hidden for GCC < 5. That's how we had it before. GCC 4.x is very old. This isn't the first time it's disappointed us
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.