Refactor CPU_EXTENSIONS logic for MSVC with Clang #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
graebm
reviewed
Jul 5, 2023
graebm
approved these changes
Jul 13, 2023
graebm
reviewed
Jul 13, 2023
| file(GLOB AWS_ARCH_SRC | ||
| "source/intel/asm/*.c" | ||
| if(AWS_ARCH_INTEL) | ||
| # First, check if inline assembly is available. Inline assembly can also be supported by MSVC if the compiler in use is Clang. |
There was a problem hiding this comment.
dogs and cats
living together
mass hysteria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
visualc_crc32c_sse42.cfails to compile on MSVC with Clang because we don't compile it with the AVX or AVX2 flag. Since inline assembly is supported by Clang even on MSVC, first check if we can use that. This will fix the #66.TODO: fix warnings and add CI for MSVC with Clang.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.