Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultChild #2290

Closed
eladb opened this issue Apr 15, 2019 · 0 comments · Fixed by #2684 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

defaultChild #2290

eladb opened this issue Apr 15, 2019 · 0 comments · Fixed by #2684 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Assignees
@eladb
Labels
feature-request A feature should be added or improved. package/awscl Cross-cutting issues related to the AWS Construct Library package/cfn Related to the CFN layer (L1)

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019 •
edited
Loading

Add ConstructNode.defaultChild: Construct which will return the child named Default or Resource and will be used as an escape hatch idiom instead of findChild("Resource").
@eladb eladb added the feature-request A feature should be added or improved. label Apr 15, 2019
@eladb eladb mentioned this issue Apr 15, 2019
Closed
@eladb eladb added the package/cfn Related to the CFN layer (L1) label Apr 15, 2019
@eladb eladb added package/awscl Cross-cutting issues related to the AWS Construct Library and removed package/awscl Cross-cutting issues related to the AWS Construct Library labels May 1, 2019
eladb pushed a commit that referenced this issue May 30, 2019
feat(core): node.defaultChild
459926c 
Convinience property which returns the child with id "Resource"
or "Default" (fails if there are both).

This is useful in order to enable escape hatching.

Closes #2290
@eladb eladb mentioned this issue May 30, 2019
Merged
4 tasks
@eladb eladb self-assigned this May 30, 2019
eladb pushed a commit that referenced this issue May 30, 2019
feat(core): node.defaultChild as a shortcut to escape hatch (#2684)
8cd3c23 
Convenience property which returns the child with id "Resource"
or "Default" (fails if there are both).

This is useful in order to enable escape hatching.

Closes #2290
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 13, 2019
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
feature-request A feature should be added or improved. package/awscl Cross-cutting issues related to the AWS Construct Library package/cfn Related to the CFN layer (L1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): node.defaultChild as shortcut to escape hatch aws/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/cdk from 0.24.1 to 0.35.0 MechanicalRock/account-reaper
1 participant
@eladb