Top-level L2 resources should have unmangled logical IDs #1687
Assignees
Labels
@aws-cdk/core
Related to core CDK functionality
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
package/cfn
Related to the CFN layer (L1)
pr/breaking-change
This PR is a breaking change. It needs to be modified to be allowed in the current major version.
Comments
eladb
added
pr/breaking-change
|
I like it (honestly I would have liked this from the start), but this will be a MASSIVE breaking change. Easy fix is to disregard |
eladb
removed
the
package/awscl
|
This is something we should consider for v2.0 (added to the v2.0 issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Customers expect that when they add L2 resources directly to the
Stack, theidthey provide for the L2 will be the logical ID of the underlying L1 resource. This will also clean up the logical IDs of deCDK resource (#1618).Aside from this being a huge breaking change, and we should probably allow people to disable this behavior for backwards compat. I don't see why we shouldn't implement this heuristic.
Change logical ID to "Default" (or ".") and then
defaultChild(#2290) should be the way to access these resources.@rix0rrr @RomainMuller @sam-goodwin what do you guys think?
The text was updated successfully, but these errors were encountered: