Update Config File Parsing Logic to Parse Services Section #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
graebm
reviewed
Jan 7, 2025
source/aws_profile.c
Outdated
Comment on lines
870
to
871
| if (s_parse_by_token(profile_cursor, s_profile_token, NULL) && | ||
| s_parse_by_character_predicate(profile_cursor, s_is_whitespace, NULL, 1)) { |
There was a problem hiding this comment.
bug in theory: if s_parse_by_token() returns true but s_parse_by_character_predicate() returns false, then profile_cursor is unexpectedly advanced, and the next if (s_parse_by_token(.... block will do unexpected things.
So like it starts with invalid nonsense like "profilesso-session", then the first if-block in this function will advance the cursor to be "sso-session" and then the second if-block would pass, but like ... neither should pass
There was a problem hiding this comment.
Thanks, that's a great catch. I have fixed it and added a test.
graebm
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs/aws-crt-swift#308
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.