Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full object checksum #468

Merged
merged 57 commits into from
Dec 6, 2024
Merged

Support full object checksum #468

merged 57 commits into from
Dec 6, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Dec 2, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review December 2, 2024 22:00
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.18519% with 28 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (45894ed) to head (4df9989).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
source/s3_checksums.c 82.65% 17 Missing ⚠️
source/s3_auto_ranged_put.c 80.64% 6 Missing ⚠️
source/s3_request_messages.c 84.37% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   89.64%   89.52%   -0.13%     
==========================================
  Files          20       20              
  Lines        6144     6213      +69     
==========================================
+ Hits         5508     5562      +54     
- Misses        636      651      +15     
Files with missing lines Coverage Δ
source/s3_checksum_stream.c 74.07% <100.00%> (ø)
source/s3_chunk_stream.c 76.87% <100.00%> (ø)
source/s3_client.c 90.55% <ø> (+0.46%) ⬆️
source/s3_meta_request.c 91.93% <100.00%> (+0.04%) ⬆️
source/s3_util.c 97.15% <100.00%> (+0.01%) ⬆️
source/s3_request_messages.c 74.50% <84.37%> (-0.27%) ⬇️
source/s3_auto_ranged_put.c 92.22% <80.64%> (-0.57%) ⬇️
source/s3_checksums.c 85.78% <82.65%> (-3.98%) ⬇️

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (previously reviewed in private repo)

@TingDaoK TingDaoK merged commit 337155f into main Dec 6, 2024
34 checks passed
@TingDaoK TingDaoK deleted the support-full-object-checksum branch December 6, 2024 17:18
github-merge-queue bot pushed a commit to awslabs/mountpoint-s3 that referenced this pull request Dec 10, 2024
Update the CRT libraries to the latest releases. In particular, include:
* Support full object checksum and crc64nvme.
([awslabs/aws-c-s3#468](awslabs/aws-c-s3#468))

<details>
  <summary>Full CRT changelog:</summary>
  
```
Submodule mountpoint-s3-crt-sys/crt/aws-c-common be8ed873..fadfef49:
  > Support relative paths when prebuilding dependencies with CMake (#1174)
  > Switch CI to use roles (#1173)
Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 45894ed3..337155f6:
  > Support full object checksum (#468)
  > [meta request]: assign shutdown_callback inside critical region (#470)
  > Switch CI to use roles (#463)
```
</details>

### Does this change impact existing behavior?

No.

### Does this change need a changelog entry?

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

Signed-off-by: Alessandro Passaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants