-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full object checksum #468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Graeb <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
- Coverage 89.64% 89.52% -0.13%
==========================================
Files 20 20
Lines 6144 6213 +69
==========================================
+ Hits 5508 5562 +54
- Misses 636 651 +15
|
DmitriyMusatkin
approved these changes
Dec 5, 2024
This was referenced Dec 5, 2024
graebm
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (previously reviewed in private repo)
github-merge-queue bot
pushed a commit
to awslabs/mountpoint-s3
that referenced
this pull request
Dec 10, 2024
Update the CRT libraries to the latest releases. In particular, include: * Support full object checksum and crc64nvme. ([awslabs/aws-c-s3#468](awslabs/aws-c-s3#468)) <details> <summary>Full CRT changelog:</summary> ``` Submodule mountpoint-s3-crt-sys/crt/aws-c-common be8ed873..fadfef49: > Support relative paths when prebuilding dependencies with CMake (#1174) > Switch CI to use roles (#1173) Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 45894ed3..337155f6: > Support full object checksum (#468) > [meta request]: assign shutdown_callback inside critical region (#470) > Switch CI to use roles (#463) ``` </details> ### Does this change impact existing behavior? No. ### Does this change need a changelog entry? No. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Alessandro Passaro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Don't merge until S3 fully supports the new feature.-> As CRT don't change the default behavior and "most" of our downstream user has its own default checksum setting. CRT can be merged before SDKs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.