Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to 3.9 #686

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Update CMake to 3.9 #686

merged 11 commits into from
Oct 23, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Oct 17, 2024

Description of changes:

  • Update CMake to 3.9
  • Disable ArrayBound warning
  • Remove aws_future_bool manual implementation and use the macro.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (e363740) to head (fb31979).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   80.40%   80.15%   -0.25%     
==========================================
  Files          28       28              
  Lines        5995     5965      -30     
==========================================
- Hits         4820     4781      -39     
- Misses       1175     1184       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 changed the title WIP | Update Cmake Update CMake to 3.9 Oct 18, 2024
@waahm7 waahm7 marked this pull request as ready for review October 18, 2024 18:20
@waahm7 waahm7 merged commit fe93d0a into main Oct 23, 2024
39 checks passed
@waahm7 waahm7 deleted the update-cmake branch October 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants