Update secure_channel_tls_handler.c #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix memory leak.
|
Thanks so much for this submission! I took these changes and made some more. I'll take this over in the other PR |
graebm
added a commit
that referenced
this pull request
Jul 10, 2024
**Issue:** A C++ SDK user found a memory leak in the Windows TLS channel-handler code and submitted the following PR: #651 In evaluating this 2-line fix, I noticed that it sat in the middle of some (preexisting) sloppy error-handling. **Description of changes:** - Fix memory leak, as shown in @normanade's PR, by calling `FreeContextBuffer()`. - Change it so we **always** call `FreeContextBuffer()` after calling to `AcceptSecurityContext()`/`InitializeSecurityContextA()`. Previously we'd only free the buffer in certain circumstances, and were probably leaking. - Remove (often sloppy) error-handling that tries to deal with allocation failures of `aws_io_message`. Officially declare that message allocations can't fail. - NOTE: Ever since [this change in 2021](awslabs/aws-c-common#830), our allocators will never return `NULL`. They deal with OOM by immediately terminating the program. This was done because error-handling code for allocation failure makes everything so much more complex, and it's seldom tested. We tried for years to handle it. It's not worth the effort. - Fix some error-handling that forgot to delete the `aws_io_message` after checking its capacity - In the Windows TLS code, replace some `AWS_ASSERT()` about buffers being large enough with `AWS_FATAL_ASSERT()`. Similarly, add an `AWS_FATAL_ASSERT()` in one place that never checked or asserted before doing the copy. - I don't know enough about TLS or Windows APIs to say whether or not these deserve real error-handling. So I'm just preserving the status quo (but crashing instead of doing undefined behavior). Co-authored-by: @normanade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak.
Issue from aws-sdk-cpp if available: S3Client Uploading Leaks Memory on Windows caused by InitializeSecurityContext misuse
Description of changes: add free for InitializeSecurityContext
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.