revert function rename

awslabs · Nov 8, 2024 · 600421e · 600421e
1 parent 5d22a69
commit 600421e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/source/windows/iocp/pipe.c b/source/windows/iocp/pipe.c
@@ -252,7 +252,7 @@ int aws_pipe_init(
         }
     }
 
-    int err = aws_event_loop_connect_handle_to_completion_port(write_end_event_loop, &write_impl->handle);
+    int err = aws_event_loop_connect_handle_to_io_completion_port(write_end_event_loop, &write_impl->handle);
     if (err) {
         goto clean_up;
     }
@@ -283,7 +283,7 @@ int aws_pipe_init(
         goto clean_up;
     }
 
-    err = aws_event_loop_connect_handle_to_completion_port(read_end_event_loop, &read_impl->handle);
+    err = aws_event_loop_connect_handle_to_io_completion_port(read_end_event_loop, &read_impl->handle);
     if (err) {
         goto clean_up;
     }

diff --git a/source/windows/iocp/socket.c b/source/windows/iocp/socket.c
@@ -2556,7 +2556,7 @@ int aws_socket_assign_to_event_loop(struct aws_socket *socket, struct aws_event_
     }
 
     socket->event_loop = event_loop;
-    return aws_event_loop_connect_handle_to_completion_port(event_loop, &socket->io_handle);
+    return aws_event_loop_connect_handle_to_io_completion_port(event_loop, &socket->io_handle);
 }
 
 struct aws_event_loop *aws_socket_get_event_loop(struct aws_socket *socket) {

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -17,7 +17,7 @@ endmacro()
 add_test_case(io_library_init)
 add_test_case(io_library_init_cleanup_init_cleanup)
 
-# DEBUG: temporarily disable the pipe related tests
+# Dispatch Queue does not support pipe
 if(NOT AWS_EVENT_LOOP_DISPATCH_QUEUE_OVERRIDE)
 add_pipe_test_case(pipe_open_close)
 add_pipe_test_case(pipe_read_write)
@@ -39,7 +39,7 @@ add_test_case(event_loop_canceled_tasks_run_in_el_thread)
 
 if(USE_IO_COMPLETION_PORTS)
     add_test_case(event_loop_completion_events)
-elseif(NOT AWS_EVENT_LOOP_DISPATCH_QUEUE_OVERRIDE) # TODO: setup a test for dispatch queue once pipe is there.
+elseif(NOT AWS_EVENT_LOOP_DISPATCH_QUEUE_OVERRIDE) # Dispatch Queue does not support pipe
     add_test_case(event_loop_subscribe_unsubscribe)
     add_test_case(event_loop_writable_event_on_subscribe)
     add_test_case(event_loop_no_readable_event_before_write)