Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection shutdown with buffered data #482

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Aug 5, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review August 5, 2024 22:52
@TingDaoK TingDaoK changed the title Connection shutdown Connection shutdown with buffered data Aug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (b5684c7) to head (c9cfa04).

Files Patch % Lines
source/h1_connection.c 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   79.51%   79.45%   -0.07%     
==========================================
  Files          27       27              
  Lines       11661    11689      +28     
==========================================
+ Hits         9272     9287      +15     
- Misses       2389     2402      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TingDaoK TingDaoK merged commit 7db2452 into main Aug 7, 2024
36 checks passed
@TingDaoK TingDaoK deleted the connection-shutdown branch August 7, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants