avoid overflowing pointers passed to memcpy #874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After executing the for-loop in
aws_array_list_mem_swap
, the pointersitem1
anditem2
could be one past the boundaries. Therefore, both pointers could be outside the address space of the program and result in undefined behavior according to the C99 as follows (7.21.1 par 2):Issue: diffblue/cbmc#6472.
Description of changes: stop calling
memcpy
if theremainder
is zero.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.