Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memtrace: Fix underflow when stack_depth < FRAMES_TO_SKIP #873

Merged
merged 2 commits into from
Apr 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/memtrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ static void s_alloc_tracer_track(struct alloc_tracer *tracer, void *ptr, size_t
/* capture stack frames, skip 2 for this function and the allocation vtable function */
AWS_VARIABLE_LENGTH_ARRAY(void *, stack_frames, (FRAMES_TO_SKIP + tracer->frames_per_stack));
size_t stack_depth = aws_backtrace(stack_frames, FRAMES_TO_SKIP + tracer->frames_per_stack);
if (stack_depth) {
if (stack_depth >= FRAMES_TO_SKIP) {
/* hash the stack pointers */
struct aws_byte_cursor stack_cursor =
aws_byte_cursor_from_array(stack_frames, stack_depth * sizeof(void *));
Expand Down
Loading