Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satisfy some signed vs unsigned comparison warnings #809

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

KaibaLopez
Copy link
Contributor

Issue #, if available:
from the cpp-sdk #1646
Description of changes:
Had a comparison with an unsigned long to a negative value which triggered warnings, and similarly an unsigned to a signed value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm changed the title changed 2 variables types to match their comparisons satisfy some signed vs unsigned comparison warnings Jul 9, 2021
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.27%. Comparing base (24da21d) to head (61edfa2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files          57       57           
  Lines        5812     5812           
=======================================
  Hits         4840     4840           
  Misses        972      972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmklix jmklix merged commit 86a056c into main Apr 29, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants