Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print both raw and resolved stack trace, helps in release builds #540

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

justinboswell
Copy link
Contributor

@justinboswell justinboswell commented Nov 7, 2019

Also fixes a couple crashes that are possible when the symbol resolves to only an address of the form [0x<addr>]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@justinboswell justinboswell requested a review from a team November 7, 2019 19:55
Copy link
Contributor

@ColdenCullen ColdenCullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix and ship

source/posix/system_info.c Outdated Show resolved Hide resolved
source/posix/system_info.c Outdated Show resolved Hide resolved
source/posix/system_info.c Outdated Show resolved Hide resolved
@justinboswell justinboswell merged commit 1906857 into master Nov 7, 2019
@justinboswell justinboswell deleted the stacktrace branch November 7, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants