aws_task_run #228
Merged
aws_task_run #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my_long_task_name->fn(my_long_task_name, my_long_task_name->arg, AWS_TASK_STATUS_LONG_ENUM);
ColdenCullen
force-pushed
the
aws_task_run
branch
from
1682873 to
012971a
Compare
JonathanHenson
approved these changes
Jan 8, 2019
| @@ -51,6 +51,11 @@ AWS_STATIC_IMPL void aws_task_init(struct aws_task *task, aws_task_fn *fn, void | |||
| task->arg = arg; | |||
| } | |||
|
|
|||
| AWS_STATIC_IMPL void aws_task_run(struct aws_task *task, enum aws_task_status status) { | |||
| assert(task->fn); | |||
There was a problem hiding this comment.
[nitpick] should we assert(task) too while we're at it?
There was a problem hiding this comment.
I mean, it'll crash here, in the assert, soooo solid maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my_long_task_name->fn(my_long_task_name, my_long_task_name->arg, AWS_TASK_STATUS_LONG_ENUM);By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.