Implementation of Robin Hood hashing for AWS C Common #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we endup with unused function errors because we attempt to compile .c files that are meant for inclusion within other .c files.
cmov is not always available on 32bit machines, and also benchmarking cmove against jnc yields no significant difference; in fact, in some cases (clang compiles) it resulted in faster code. Removing the #ifdef for cmov allows us to test the 32bit code on 64bit machines used by developers and CI. Which avoids surprise errors like the compile error of "label redefinition" which I also fixed in this commit.
* Use symbolic names in some places * Fix more missing earlyclobber operands
* Use aws_raise_error to report errors and update tests accordingly) * Use bitmask for foreach callback, and add a test for it * Code style changes
graebm
added a commit
that referenced
this pull request
Nov 27, 2024
**Issue** A recent PR #1170 (comment) fixed an indexing-math bug in this test. When I took a closer look at this test, I noticed it was broken ... and didn't make much sense **Research:** This hash table test was added with the original hash table PR #17. That branch had 2 different authors, which seems to have led to the brokenness - Original [commit](c2a7f08) with this test - In this [commit](ab4e987), author B accidentally replaces floating-point-rand with integer-rand, breaking randomness so this test doesn't actually test anything anymore - In this [commit](fe71f05), Author A removes some `entries[i -1]` checks that don't really make sense because `entries` isn't sorted - In this [commit](a36d2dd), Author B brings the checks back. My guess is there was a merge conflict and they just accepted their own side **Description of changes** - Fix randomness - Add comments about what this test is doing - Fix the checks, using the `sorted_entries` array instead of the unsorted `entries` array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is based off of the original PR by @bdonlan #13.
Changes from the PR include:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.