disable visibility hidden on old gcc

[DmitriyMusatkin]

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (f882188) to head (fd387eb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          57       57           
  Lines        5953     5953           
=======================================
  Hits         4979     4979           
  Misses        974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[graebm]

trivial/debatable: easier to read broken into 2 separate if-statements
also, you split the 3 related sentences about DEBUG and backtraces and memory leaks in half

Suggested change

	# And dont hide symbols on anything pre GCC 5.0 (Visibility support was not great on older compilers and some libraries didnt annotate visibility -
	# looking at you jni, which does not annotate on gcc less than 4.2. Mixing no annotation and hidden symbols leads to unexpected failures.).
	# We do this so that backtraces are more likely to show function names.
	# We mostly use backtraces to diagnose memory leaks.
	if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
	if ((NOT CMAKE_BUILD_TYPE STREQUAL "Debug") AND NOT (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0"))
	set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON)
	endif ()
	# Don't hide symbols in Debug builds.
	# We do this so that backtraces are more likely to show function names.
	# We mostly use backtraces to diagnose memory leaks.
	if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
	# And dont hide symbols on anything pre GCC 5.0 (Visibility support was not great on older compilers and some libraries didnt annotate visibility -
	# looking at you jni, which does not annotate on gcc less than 4.2. Mixing no annotation and hidden symbols leads to unexpected failures.).
	if (NOT (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0"))
	set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON)
	endif ()
	endif ()

[TingDaoK]

🕵️