Add IS_CXX option to sanitizer cmake module #1135
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws_check_sanitizer
checks for the sanitizer flags usingcheck_c_compiler_flag
. However, for C++ projects C language could be not enabled, which leads to the following error:A possible solution could be to add
enable_language(C)
before callingcheck_c_compiler_flag
. But I'm not sure that C++ and C compilers have the same set of the sanitizer options. And even if they do currently, this might change.So, using
check_cxx_compiler_flag
for C++ project looks like a more correct approach.Description of changes:
Add
IS_CXX
option toaws_check_sanitizer
andaws_add_sanitizers
CMake functions.This change does not break or change the existing usages of these functions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.