Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid cpu_id for RHEL_5 #1106

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix invalid cpu_id for RHEL_5 #1106

merged 1 commit into from
Apr 22, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Apr 22, 2024

Description of changes:

  • If the CPU id value is too high, it can result in a seg fault instead of just pthread_create call failing with an error. Lower the value to 512 which will still make it invalid as of now but it won't be too large.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.27%. Comparing base (70b8fcd) to head (fd69e03).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   83.27%   83.27%   -0.01%     
==========================================
  Files          57       57              
  Lines        5813     5812       -1     
==========================================
- Hits         4841     4840       -1     
  Misses        972      972              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit 5038bc1 into main Apr 22, 2024
52 checks passed
@waahm7 waahm7 deleted the fix_invalid_cpu_id_test_rhel5 branch April 22, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants