Use _Exit() on test failure, to avoid LeakSanitizer spam #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
approved these changes
Feb 8, 2024
graebm
commented
Feb 8, 2024
| @@ -478,7 +481,8 @@ static inline int s_aws_run_test_case(struct aws_test_harness *harness) { | |||
| const size_t leaked_bytes = aws_mem_tracer_bytes(allocator); | |||
| if (leaked_bytes) { | |||
| aws_mem_tracer_dump(allocator); | |||
| PRINT_FAIL_INTERNAL0("Test leaked memory: %zu bytes %zu allocations", leaked_bytes, leaked_allocations); | |||
| PRINT_FAIL_WITHOUT_LOCATION( | |||
There was a problem hiding this comment.
It always annoyed me how the final "test leaked" and "test failed" messages printed their file location and line no. It made it look like the aws_test_runner.h code is what had bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut down on unrelated spam when a test fails.
_Exit() is in C99. It avoids running cleanup functions on program termination.
This does prevent us from running multiple tests via the
aws-c-common-testsexecutable, but we never ever do that. We always usectest, which launches each test in its own process. I literally only learned today that you can pass-Ato run all tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.