-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a query string helper from byte cursor directly #1080
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
+ Coverage 83.30% 83.31% +0.01%
==========================================
Files 56 56
Lines 5804 5808 +4
==========================================
+ Hits 4835 4839 +4
Misses 969 969 ☔ View full report in Codecov by Sentry. |
source/uri.c
Outdated
bool aws_uri_query_string_next_param(const struct aws_uri *uri, struct aws_uri_param *param) { | ||
return aws_query_string_next_param(uri->query_string, param); | ||
} | ||
|
||
int aws_uri_query_string_params(const struct aws_uri *uri, struct aws_array_list *out_params) { | ||
struct aws_uri_param param; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible, just have aws_uri_query_string_params() call into aws_query_string_params()
include/aws/common/uri.h
Outdated
* 2) Blank entries are skipped. | ||
* Example: The only param in query string "&&a=b" is key="a" value="b" | ||
*/ | ||
AWS_COMMON_API bool aws_query_string_next_param(struct aws_byte_cursor query_string, struct aws_uri_param *param); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that other PR how do you plan to go from path_and_query
to just query
? Does that necessitate another helper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix & ship
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.