Apple assert fix #121
Merged
Apple assert fix #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_byte_buf was asserting on Apple platforms due to capacity not being set. Fixed by using aws_byte_buf_from_array() function, instead of setting struct members directly. Also changed similar (but bug-free) Windows code to use aws_byte_buf_from_array(), for consistency
Previously, we accidentally skipped testing due to complex loops. Fixed by making the loops even more complex.
TingDaoK
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE 1: Debug builds on Apple were hitting asserts due to an
aws_byte_bufwherecapacitywasn't set. Fixed by usingaws_byte_buf_from_array(), instead of setting struct members directly.ISSUE 2: Tests on 0-length input didn't actually DO anything. This was due to complicated loops in the tests. Fixed by making the loops even more complicated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.