Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multiple Shutdown Callback for Profile with STS Code Path #251

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Sep 6, 2024

*Issue#: awslabs/aws-crt-swift#280
Description of changes:

  • Shutdown options were copied over to the sts chain due to a bug. Change the struct copy to explicit fields instead of a shallow copy. Due to the shutdown options copy, we were triggering the shutdown callback multiple times.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 marked this pull request as ready for review September 6, 2024 20:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (e930f1a) to head (18d42c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files          33       33           
  Lines        6044     6045    +1     
=======================================
+ Hits         4857     4858    +1     
  Misses       1187     1187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit d5e6eb0 into main Sep 12, 2024
30 checks passed
@waahm7 waahm7 deleted the fix-double-free-sts branch September 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants