Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service specific presign #249

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Service specific presign #249

merged 5 commits into from
Sep 5, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Sep 4, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (1de5445) to head (5c5dcd1).

Files with missing lines Patch % Lines
source/aws_signing.c 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   80.40%   80.36%   -0.05%     
==========================================
  Files          33       33              
  Lines        6038     6044       +6     
==========================================
+ Hits         4855     4857       +2     
- Misses       1183     1187       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TingDaoK TingDaoK merged commit 3281f86 into main Sep 5, 2024
30 checks passed
@TingDaoK TingDaoK deleted the service-specific-presign branch September 5, 2024 21:52
graebm pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants