Fix bugs 2 #116
Merged
Fix bugs 2 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victornicolet
requested review from
samarth-aws and
amzn-jasonrk
and removed request for
samarth-aws
samarth-aws
reviewed
Nov 20, 2024
analysis/config/config.go
Outdated
| // Get absolute path to config. Other files in config will be relative to where the config is. | ||
| pathToConfig := filename | ||
| if !path.IsAbs(filename) { | ||
| wd, _ := os.Getwd() |
There was a problem hiding this comment.
Should probably return the error
| @@ -226,7 +227,8 @@ func TestLoadVersionBefore_v0_3_0_Errors(t *testing.T) { | |||
|
|
|||
| func TestLoadWithReports(t *testing.T) { | |||
| c := NewDefault() | |||
| c.ReportsDir = "example-report" | |||
| wd, _ := os.Getwd() | |||
| c.ReportsDir = path.Join(wd, "testdata/example-report") | |||
There was a problem hiding this comment.
I think filepath.Join is preferred over path.Join for better OS compatibility: https://pkg.go.dev/path/filepath#Join
analysis/load_program.go
Outdated
| // If it's a named target, need to change to project root's directory to properly load the target | ||
| err := os.Chdir(cfg.Root()) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
nit: missing error context
victornicolet
force-pushed
the
fix-bugs-2
branch
from
0e34095
to
ff35ba9
Compare
samarth-aws
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in the code: