Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade client_golang Dependency #32

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

forestmvey
Copy link
Contributor

Summary

Update client_golang dependency to resolve security dependabot alert.

Description

Update client_golang dependency to resolve Uncontrolled Resouce Consumption in promhttp security issue. Post upgrade a type error occured with kingpin dependency. Using standard import with github url resolved the type error in call to flag.AddFlags.

Fixes post upgrade:

  • Resolve type error with gopkg.in service import.
    • cannot use a (variable of type *"gopkg.in/alecthomas/kingpin.v2".Application) as *"github.com/alecthomas/kingpin/v2".Application value in argument to flag.AddFlags

Verification

  • Test remote write and read queries running connector locally:
    • With default database and table
    • With database and table labels
  • Validate IT tests pass

Resolved Issues:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sethusrinivasan sethusrinivasan merged commit b789bc3 into main Nov 14, 2023
4 checks passed
@alexey-temnikov alexey-temnikov deleted the forestmvey/update-client_golang-dependency branch May 7, 2024 04:03
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…olang-dependency

Upgrade client_golang Dependency
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…olang-dependency

Upgrade client_golang Dependency
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…olang-dependency

Upgrade client_golang Dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants