Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repository with Improved Useability with SAM Template #27

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Update Repository with Improved Useability with SAM Template #27

merged 1 commit into from
Oct 4, 2023

Conversation

forestmvey
Copy link
Contributor

Update repository with latest changes. Repository was missing remote read support that must not have been merged in with the initial commit for this repository. Major improvements towards 1-click deployment are added with this PR including an updated template for SAM deployment.

Description of changes:

  • Added ability to set default database and table for connector to avoid mapping database and table labels
    • Avoids label mapping that is not necessary and may add confusion for new users
  • Added support for read endpoint requests through connector
    • Missing from repository. Associated logic changes and testing has been added
  • Merged SAM templates to one template
    • Simplify deployment by allowing one template to be deployed to cloudformation
  • Add 1-click deployment section to DEVELOPER_GUIDE (WIP)
    • Currently WIP, needs minor changes to template and deployment to public s3 bucket with connector
  • Added GHA workflow for trufflehog
    • Scans for inappropriate secrets stored in source code
  • Updated snappy library to support ARM64
    • Coretex run-time error resolved with updating snappy, Issue: 62
  • Added note for testing to be done before contributing to repository with PR under CONTRIBUTING.MD

Validation steps completed:

  • Deployed connector to cloudformation using 1-click deployment with configurations set for default database, default table, database labels and table labels

    • Validated successful ingestion from prometheus to timestream database table using default database/table
    • Validated successful ingestion from prometheus to timestream database table using database/table labels
    • Validated successful read requests to database table from prometheus server using default database/table
    • Validated successful read requests to database table from prometheus server using database/table labels
  • Validated running connector locally with configurations set for default database, default table, database labels and table labels

    • Validated successful ingestion from prometheus to timestream database table using default database/table
    • Validated successful ingestion from prometheus to timestream database table using database/table labels
    • Validated successful read requests to database table from prometheus server using default database/table
    • Validated successful read requests to database table from prometheus server using database/table labels
  • Validated IT tests pass locally

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…rometheus, SAM cloudformation deployment for connector, and trufflehog workflow.

Signed-off-by: forestmvey <[email protected]>
Copy link
Contributor

@sethusrinivasan sethusrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us merge these change and test it out

@sethusrinivasan sethusrinivasan merged commit 824f7a4 into awslabs:main Oct 4, 2023
4 checks passed
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…with-latest

Update Repository with Improved Useability with SAM Template
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…with-latest

Update Repository with Improved Useability with SAM Template
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…with-latest

Update Repository with Improved Useability with SAM Template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants