Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #190

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Improve logging #190

merged 2 commits into from
Mar 22, 2023

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Mar 17, 2023

This PR contains two commits that improve logging.


Avoid string concatenation in logging statements

This commit removes string concatenation in logging statements where
possible, in favor of format-based logging messages.


Tweak logging statement levels

At present, for every JMS message sent there are the following 2
statements logged at info level:

  • messageId in SQSMessageProducer#sendInternal
  • shutting down executor in SQSSession#doClose

These result in excessive logging for systems that product a lot of JMS
messages and are really better fit for debug level.

Additionally, SQSMessageConsumer#doClose also has an equivalent logging
statement to one in SQSSession#doClose.

Finally, SQSSessionCallbackScheduler#run contains logging statement that
logs exception at info level, which is better suited for warn level.

vpavic added 2 commits March 17, 2023 23:39
This commit removes string concatenation in logging statements where
possible, in favor of format-based logging messages.
At present, for every JMS message sent there are the following 2
statements logged at info level:

- messageId in SQSMessageProducer#sendInternal
- shutting down executor in SQSSession#doClose

These result in excessive logging for systems that product a lot of JMS
messages and are really better fit for debug level.

Additionally, SQSMessageConsumer#doClose also has an equivalent logging
statement to one in SQSSession#doClose.

Finally, SQSSessionCallbackScheduler#run contains logging statement that
 logs exception at info level, which is better suited for warn level.
@ziyanli-amazon ziyanli-amazon merged commit 3c900f7 into awslabs:master Mar 22, 2023
@vpavic vpavic deleted the tweak-logging branch March 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants