Closes #68 #69
Merged
Closes #68 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we send updated SendMessageBatchRequest entries when message payload is transfered through s3.
adam-aws
reviewed
Jan 3, 2022
| } | ||
| batchEntries.add(entry); | ||
| } | ||
|
|
||
| if (hasS3Entries) { |
There was a problem hiding this comment.
Good catch, do we actually need this hasS3Entries ? Since batchEntries will contain the actual entries we want to send (some might be s3 pointers and some might be the actual message) we can update the entries for the sendMessageBatchRequest every-time.
There was a problem hiding this comment.
I guess just to avoid having to copy the new entries.
There was a problem hiding this comment.
thanks for quick response! and for merging the PR :D
adam-aws
approved these changes
Jan 3, 2022
adam-aws
added a commit
that referenced
this pull request
Jan 3, 2022
adam-aws
added a commit
that referenced
this pull request
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we send updated SendMessageBatchRequest entries when message payload is transferred through s3.
Issue #68
Description of changes:
Fixes the issue when messages are sent raw even though payload was uploaded to s3. Need to send reference to s3 bucket instead of the actual message in this case.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.