Issue 55 #56
Merged
Issue 55 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -354,6 +354,9 @@ public ReceiveMessageResult receiveMessage(ReceiveMessageRequest receiveMessageR | |||
| Optional<String> largePayloadAttributeName = getReservedAttributeNameIfPresent(message.getMessageAttributes()); | |||
| if (largePayloadAttributeName.isPresent()) { | |||
| String largeMessagePointer = message.getBody(); | |||
| largeMessagePointer = largeMessagePointer.contains("software.amazon.payloadoffloading.PayloadS3Pointer") ? | |||
There was a problem hiding this comment.
String manipulation of JSON seems uncouth. Anyway, beyond that I guess it doesn't matter much but:
- this
containsseems unnecessary since the replace will no-op if it's not present replaceFirstis regex-based, so the raw/unescaped.are matching any character; perhaps just usereplace(CharSequence, CharSequence)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #55
Description of changes:
Allow consumer in ReceiveMessage call to convert a MessageS3Pointer payload:
["com.amazon.sqs.javamessaging.MessageS3Pointer", {"s3BucketName": "...", "s3Key": "..."}]to:
["software.amazon.payloadoffloading.PayloadS3Pointer", {"s3BucketName": "...", "s3Key": "..."}]Allowing users to upgrade to version 1.1.x from 1.0.x and still be able to receive either MessageS3Pointer or PayloadS3Pointer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.