Deprecate ExtendedClientConfiguration functions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-rizi
suggested changes
Jul 28, 2020
src/test/java/com/amazon/sqs/javamessaging/ExtendedClientConfigurationDeprecatedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientDeprecatedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientDeprecatedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientDeprecatedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientDeprecatedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientDeprecatedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientDeprecatedTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
32
to
35
| @Before | ||
| public void setup() { | ||
|
|
||
| } |
There was a problem hiding this comment.
Removed empty setup
There was a problem hiding this comment.
thanks a lot for all the changes.
Just one more thing that we need to be careful about is the constants are shared with SNSExtendedClient.
Could you please add some comments on
public static final String RESERVED_ATTRIBUTE_NAME = "ExtendedPayloadSize";
To emphasize that this constant is shared with SNSExtendedClient and both are using that as an agreement and it must not be changed, otherwise will break the codes.
Thanks a lot
There was a problem hiding this comment.
Added comment to this constant
src/test/java/com/amazon/sqs/javamessaging/ExtendedClientConfigurationDeprecatedTest.java
Outdated
Show resolved
Hide resolved
aws-rizi
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Deprecate ExtendedClientConfiguration functions since will be using payload offloading common lib which has different function names
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.