Implement Payload Offloading Java Common Library For AWS #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-aws
commented
Jul 20, 2020
| super(sqsClient); | ||
| this.clientConfiguration = new ExtendedClientConfiguration(extendedClientConfig); | ||
| if (payloadStorageConfiguration.getPayloadSizeThreshold() == 0) { |
There was a problem hiding this comment.
Since PayloadStorageConfiguration variable payloadSizeThreshold by default is 0, setting it to SQS default value. Let me know if I should go for another approach.
aws-rizi
suggested changes
Jul 22, 2020
src/main/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/sqs/javamessaging/SQSExtendedClientConstants.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/ExtendedClientConfigurationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/ExtendedClientConfigurationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/sqs/javamessaging/ExtendedClientConfiguration.java
Show resolved
Hide resolved
src/main/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientBase.java
Show resolved
Hide resolved
aws-rizi
suggested changes
Jul 22, 2020
aws-rizi
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #51
Description of changes:
Implement Payload Offloading Java Common Library For AWS. Will cause breaking changes since ExtendedClientConfiguration is replaced by PayloadStorageConfiguration.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.