Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change cgroup driver to systemd (#521)" #587

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Revert "Change cgroup driver to systemd (#521)" #587

merged 1 commit into from
Dec 17, 2020

Conversation

abeer91
Copy link
Contributor

@abeer91 abeer91 commented Dec 17, 2020

This reverts commit f9d2c39.

Description of changes:

EksCtl uses a nodebootsrap process where it configures the kubelet config, but not the docker config

Before we revert this commit, we need to finalize on how we can safely update eksctl to also set these values.

https://github.com/weaveworks/eksctl/blob/1555c35b1b315ff31c062a789c5f756a6122d057/docs/current-001-node_bootstrap.md

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abeer91 abeer91 merged commit 4793e3d into awslabs:master Dec 17, 2020
@reegnz
Copy link
Contributor

reegnz commented Dec 17, 2020

I don't necessarily understand why a revert. A tool downstream is breaking, why should that influence what happens in the upstream?

@reegnz
Copy link
Contributor

reegnz commented Dec 17, 2020

@abeer91 Also could you please link to the ticket in eksctl that tracks this issue, so we can re-apply the change once the downstream manages to fix their incompatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants