Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2704 added in option for temporary security group source cidr #253

Conversation

houdinisparks
Copy link
Contributor

Issue #, if available:
#252

Description of changes:
Added the following configurable variables:

  • ssh_username
  • temporary_security_group_source_cidrs
  • ssh_interface
  • subnet_id
  • associate_public_ip_address
  • ami_description

This is also meant to fix the issue of allowing EKS AMI's to be built into an account without a default vpc + restricted ssh access with private ip + initiate outbound internet connection by explicitly setting "associate_public_ip_address": "true".

Note: I am currently referencing this module as a .gitsubmodule with path "vendor/amazon-eks-ami" in my project. Variables are externally declared in a separate folder, and amis are built using packer build --var-file=<external-file> vendor/amazon-eks-ami command

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

yanyee wong added 5 commits April 27, 2019 11:39
  * ssh_username
  * ssh_interface
  * temporary_security_group_source_cidrs
  * associate_public_ip_address

This is to allow amis to have restricted ssh access during build time with private ips, and also be able to initiate outbound connection to the internet with a public ip.
…it doesnt matter where packer build command is running
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, can you scope down your changes to just passing the packer args via the parameters and remove the whitespace and field modifications not required for this change?

Thank you!

@houdinisparks
Copy link
Contributor Author

removing this PR in favour of #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants