feat(al2023): cache and retag pause container

[ndbaker1]

Issue #, if available:

Description of changes:

In the past we've added/removed pause container image caching due to various issues with image GC and regional images. here I'm bringing back image caching for AL2023 and retagging the image to remove the association with the image's registry

the new field pause_container_image will be necessary when building AMIs in an environment that cannot hit the configured default ecr uri (in us-west-2)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

[cartermckinnon]

Looks like we can probably use a shared provisioner for the caching logic?

[ndbaker1]

Looks like we can probably use a shared provisioner for the caching logic?

yea good call, it might require a lot of the same env vars but i prefer the isolation & reuse with different provisioners

[ndbaker1]

gonna go ahead and sanity check this, i built both distros on local so it should be testable

/ci

[github-actions]

@ndbaker1 roger that! I've dispatched a workflow. 👍

[github-actions]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variant	Build	Test
1.23 / al2	success ✅	failure ❌
1.23 / al2023	success ✅	failure ❌
1.24 / al2	success ✅	success ✅
1.24 / al2023	success ✅	failure ❌
1.25 / al2	success ✅	success ✅
1.25 / al2023	success ✅	failure ❌
1.26 / al2	success ✅	success ✅
1.26 / al2023	success ✅	failure ❌
1.27 / al2	success ✅	success ✅
1.27 / al2023	success ✅	failure ❌
1.28 / al2	success ✅	success ✅
1.28 / al2023	success ✅	failure ❌
1.29 / al2	success ✅	success ✅
1.29 / al2023	success ✅	failure ❌
1.30 / al2	success ✅	success ✅
1.30 / al2023	success ✅	failure ❌

[ndbaker1]

/ci

[github-actions]

@ndbaker1 roger that! I've dispatched a workflow. 👍

[github-actions]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variant	Build	Test
1.23 / al2023	success ✅	success ✅
1.24 / al2023	success ✅	success ✅
1.25 / al2023	success ✅	success ✅
1.26 / al2023	success ✅	success ✅
1.27 / al2023	success ✅	success ✅
1.28 / al2023	success ✅	success ✅
1.29 / al2023	success ✅	success ✅
1.30 / al2023	success ✅	success ✅

[ndbaker1]

oh it only picked up al23 bc of the diff
/ci
+workflow:os_distros al2

[github-actions]

@ndbaker1 roger that! I've dispatched a workflow. 👍

[github-actions]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variant	Build	Test
1.23 / al2	success ✅	failure ❌
1.24 / al2	success ✅	success ✅
1.25 / al2	success ✅	success ✅
1.26 / al2	success ✅	success ✅
1.27 / al2	success ✅	success ✅
1.28 / al2	success ✅	success ✅
1.29 / al2	success ✅	success ✅
1.30 / al2	success ✅	success ✅

[ndbaker1]

ah it wasn't cached for docker, bc thats still supported below 1.25 and default on 1.23 🤦

[ndbaker1]

/ci
+workflow:os_distros al2,al2023

[github-actions]

@ndbaker1 roger that! I've dispatched a workflow. 👍

[github-actions]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variant	Build	Test
1.23 / al2	success ✅	failure ❌
1.23 / al2023	success ✅	success ✅
1.24 / al2	success ✅	success ✅
1.24 / al2023	success ✅	success ✅
1.25 / al2	success ✅	success ✅
1.25 / al2023	success ✅	success ✅
1.26 / al2	success ✅	success ✅
1.26 / al2023	success ✅	success ✅
1.27 / al2	success ✅	success ✅
1.27 / al2023	success ✅	success ✅
1.28 / al2	success ✅	success ✅
1.28 / al2023	success ✅	success ✅
1.29 / al2	success ✅	success ✅
1.29 / al2023	success ✅	success ✅
1.30 / al2	success ✅	success ✅
1.30 / al2023	success ✅	success ✅

[ndbaker1]

docker wasn't playing well with the importing the blob exported by ctr, so i just ripped out the related similar steps and ran them separately. not super critical since its a small image and 1.23/1.24 are soon to be EOL. should do the trick 🤞

/ci
+workflow:os_distros al2,al2023

[github-actions]

@ndbaker1 roger that! I've dispatched a workflow. 👍

[github-actions]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variant	Build	Test
1.23 / al2	success ✅	success ✅
1.23 / al2023	success ✅	success ✅
1.24 / al2	success ✅	success ✅
1.24 / al2023	success ✅	success ✅
1.25 / al2	success ✅	success ✅
1.25 / al2023	success ✅	success ✅
1.26 / al2	success ✅	success ✅
1.26 / al2023	success ✅	success ✅
1.27 / al2	success ✅	success ✅
1.27 / al2023	success ✅	success ✅
1.28 / al2	success ✅	success ✅
1.28 / al2023	success ✅	success ✅
1.29 / al2	success ✅	success ✅
1.29 / al2023	success ✅	success ✅
1.30 / al2	success ✅	success ✅
1.30 / al2023	success ✅	success ✅

[cartermckinnon]

Sanity check before merge...

/ci

[github-actions]

@cartermckinnon this PR is not currently mergeable, you'll need to rebase it first.

[cartermckinnon]

Argh sorry @ndbaker1 😭 Can you rebase this when you get a chance?

[ndbaker1]

/ci

[github-actions]

@ndbaker1 roger that! I've dispatched a workflow. 👍

[github-actions]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variant	Build	Test
1.24 / al2023	success ✅	success ✅
1.25 / al2023	success ✅	success ✅
1.26 / al2023	success ✅	success ✅
1.27 / al2023	success ✅	success ✅
1.28 / al2023	success ✅	success ✅
1.29 / al2023	success ✅	success ✅
1.30 / al2023	success ✅	success ✅
1.31 / al2023	success ✅	success ✅