Adding local file cache for credential helper #3
Conversation
| // file access. There is not guarantee here for handling multiple writes at once since there is no out of process locking. | ||
| func (f *fileCredentialCache) save(registryCache *RegistryCache) error { | ||
| defer log.Flush() | ||
| file, err := ioutil.TempFile("", "ecr-credential-cache") |
There was a problem hiding this comment.
Can you change this to use a temp file in the ~/.ecr directory? os.Rename will fail if the temp file and destination file are not on the same filesystem, so creating the temp file in the same directory would help that problem.
dir, _ := homedir.Expand("~/.ecr")
file, err := ioutil.TempFile(dir, "ecr-credential-cache")There was a problem hiding this comment.
I did not know that. 😞 Seems reasonable to keep all within ~/.ecr. I'll update, will inject homedir path into the file cache.
|
Looks good other than the temp file bit. |
This provides a JSON file cache that's serialized/deserialized for each access. The local file cache tokens are kept for the half-life of the token lifetime (i.e. a 12 hour token will get expired after 6 hours). Users may also opt-out of local cache with an environment variable set of `AWS_ECR_DISABLE_CACHE`.
|
Added temp file & rebased against master. |
|
@sentientmonkey Looks like some unit test failures. |
sentientmonkey
force-pushed
the
master
branch
2 times, most recently
from
1452bc1 to
1515736
Compare
|
Looks like it was a deep comparison issue with times. 😭 Comparing each of the values seemed to do the trick. Not exactly sure why this was failing in travis vs. locally. |
|
👍 I think my one remaining concern here is garbage collection of expired cache entries when the access key changes (like how it will rotate on an EC2 instance profile), but we can follow up with that separately. |
|
Will create issue for cleaning up expired entries - seems reasonable to purge expired entries on load or save. |
|
Added: #6 |
This provides a JSON file cache that's serialized/deserialized
for each access. The local file cache tokens are kept for the half-life
of the token lifetime (i.e. a 12 hour token will get expired after 6
hours). Users may also opt-out of local cache with an environment
variable set of
AWS_ECR_DISABLE_CACHE.