Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning silencer crashes when receiving DeprecationWarning objects #26

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

verdimrc
Copy link
Contributor

Issue #, if available: N/A

Description of changes: unbreak some cases where _warn() receives non-string objects such as DeprecationWarning objects.

Testing done: done

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're
unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of
what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have updated any necessary documentation, including README and docs (if appropriate).

By submitting this pull request, I confirm that my contribution is made under the terms of the
Apache 2.0 license.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/a2rl
   __init__.py21195%35
   simulator.py5775690%456–458, 471, 537, 543, 559–594, 600, 912, 1011, 1026, 1036, 1041, 1057, 1075, 1097, 1123, 1144, 1150, 1167, 1171, 1177, 1187, 1194, 1217, 1223, 1302, 1309, 1364, 1371, 1377, 1384, 1387, 1498, 1514–1516, 1525, 1549, 1588, 1591
   tokenizer.py116298%64–65
   utils.py1612286%51, 60–63, 74–76, 108, 147, 164, 179–181, 336–339, 475–484, 544, 558
src/a2rl/experimental/lightgpt
   lr_decay.py20195%30
   model.py116298%260, 263
   simulator.py35197%162
src/a2rl/mingpt
   model.py118497%57, 203, 208, 230
   trainer.py841483%50–51, 55–57, 108–111, 116, 124–126, 134, 140–141
TOTAL155010393% 

Tests Skipped Failures Errors Time
234 0 💤 0 ❌ 0 🔥 33.956s ⏱️

@verdimrc
Copy link
Contributor Author

LGTM, despite pandas-1.5.0 breaks mypy checks.

@verdimrc verdimrc merged commit 73884bf into main Sep 21, 2022
@verdimrc verdimrc deleted the fix/silence-warning branch September 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant