Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SageMaker model package promote modules #61

Merged
merged 21 commits into from
May 3, 2024

Conversation

lccasagrande
Copy link
Contributor

Describe your changes

  • Added sagemaker-model-event-bus module to setup event bridge buses with cross-account permissions.
  • Added sagemaker-model-package-group module to create SageMaker Model Package Groups with a resource policy granting cross-account read-only access and event bridge rules to send SageMaker Model Package change events to another event bus.
  • Added sagemaker-model-package-promote-pipeline module to create a CICD pipeline to automatically promote model packages across in a multi-account setup.

Issue ticket number and link

N/A

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking
Copy link
Contributor

kukushking commented May 1, 2024

@lccasagrande could you please update README.MD module table with the new modules? Also is it possible to keep sagemaker-model-package-group in sagemaker and move the event bus/pipeline to another group or examples/modules/ since these are not directly related to sagemaker?

EDIT: + looks like module formatting checks are off

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: a86fd3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kukushking
kukushking previously approved these changes May 3, 2024
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @lccasagrande !

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 76f94a0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kukushking
kukushking previously approved these changes May 3, 2024
@lccasagrande lccasagrande dismissed stale reviews from LeonLuttenberger and kukushking via 1084d45 May 3, 2024 20:23
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 1084d45
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 8e65044
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit 9959455 into awslabs:main May 3, 2024
14 of 15 checks passed
@kukushking
Copy link
Contributor

Thanks @lccasagrande !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants