Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CDK nags for sagemaker custom kernel module #43

Merged
merged 6 commits into from
Apr 11, 2024
Merged

fix: CDK nags for sagemaker custom kernel module #43

merged 6 commits into from
Apr 11, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Apr 10, 2024

Describe your changes

  • Downscope the CDK nag suppressions
  • Make pytest check for CDK nag errors

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review April 10, 2024 21:19
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LeonLuttenberger LeonLuttenberger merged commit 74ab7b7 into awslabs:main Apr 11, 2024
9 checks passed
@LeonLuttenberger LeonLuttenberger deleted the fix/custom-kernel-cdk-nag branch April 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants